Skip to content

get latest build version for ccp seeder#450

Open
SimplyUnnamed wants to merge 4 commits into
eveseat:masterfrom
SimplyUnnamed:feature/update_ccp_sde_latest
Open

get latest build version for ccp seeder#450
SimplyUnnamed wants to merge 4 commits into
eveseat:masterfrom
SimplyUnnamed:feature/update_ccp_sde_latest

Conversation

@SimplyUnnamed
Copy link
Copy Markdown

@SimplyUnnamed SimplyUnnamed changed the title Feature/update ccp sde latest get latest build version for ccp seeder May 18, 2026
Comment thread src/database/seeders/CcpSdeSeeder.php Outdated
/**
* Download the EVE Sde from Fuzzwork and save it
* in the storage_path/sde folder.
*/
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds a duplicate comment block.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed duplicate comment block

@Crypta-Eve
Copy link
Copy Markdown
Member

Thanks for the PR!

Can I ask for one change though. As it stands this breaks the principle of unattended upgrades being non-breaking as it means that a change in schema to the SDE that breaks how we use it could lead to non-functional instances.

So could I ask that you gate this check behind an flag, eg --latest so that people can opt in to the use of the latest SDE.

@SimplyUnnamed
Copy link
Copy Markdown
Author

This would probably have to be moved to an artisan command, as I do not believe that you are able to provide arguments into a seeder class the same way.

happy to do this, or perhaps undo these changes for simple version bump,

I understand the argument, that you want to ensure the schema does not break cause values are too long (evidence by the need to increase the length of typeName).

but there is also a balance, were new skills and items, months old can't be seen in seat yet.

@Crypta-Eve
Copy link
Copy Markdown
Member

You are right about timelines. I had intended to build a bot for auto validation on new updates so we didn't have to wait.. Hadn't got there.

Also my bad on memory, I forgot this is still just in the seeder, my dev install has started migrating this to an artisan command already.

For now can you make it an env var, and happy for you to bump the version number too.

@SimplyUnnamed
Copy link
Copy Markdown
Author

sorry been pretty busy this last week. il look at updating this pr this week,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants