Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/extensions/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@
"react-multi-email": "^0.5.3",
"react-outside-click-handler": "^1.3.0",
"react-redux": "^7.2.6",
"react-router": "^6.0.2",
"react-router": "^6.30.2",
"react-router-dom": "^6.0.2",
Comment on lines +191 to 192
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a version mismatch between react-router and react-router-dom. react-router is being updated to ^6.30.2 (which resolves to 6.30.2), while react-router-dom remains at ^6.0.2 (which resolves to 6.30.1).

In React Router v6, react-router and react-router-dom are tightly coupled and should use the same version. More importantly, they both depend on @remix-run/router, and the current versions pull in different versions of that dependency:

  • react-router@6.30.2 → @remix-run/router@1.23.1
  • react-router-dom@6.30.1 → @remix-run/router@1.23.0

This can cause issues with duplicate package resolution and potential runtime errors. You should update react-router-dom to ^6.30.2 as well to ensure both packages use the same versions of their dependencies.

Suggested change
"react-router": "^6.30.2",
"react-router-dom": "^6.0.2",
"react-router": "^6.30.2",
"react-router-dom": "^6.30.2",
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/extensions/package.json
Line: 191:192

Comment:
There is a version mismatch between react-router and react-router-dom. react-router is being updated to ^6.30.2 (which resolves to 6.30.2), while react-router-dom remains at ^6.0.2 (which resolves to 6.30.1). 

In React Router v6, react-router and react-router-dom are tightly coupled and should use the same version. More importantly, they both depend on @remix-run/router, and the current versions pull in different versions of that dependency:
- react-router@6.30.2 → @remix-run/router@1.23.1
- react-router-dom@6.30.1 → @remix-run/router@1.23.0

This can cause issues with duplicate package resolution and potential runtime errors. You should update react-router-dom to ^6.30.2 as well to ensure both packages use the same versions of their dependencies.

```suggestion
    "react-router": "^6.30.2",
    "react-router-dom": "^6.30.2",
```

How can I resolve this? If you propose a fix, please make it concise.

"react-svg": "^14.1.3",
"react-switch": "^6.0.0",
Expand Down
43 changes: 36 additions & 7 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.