fix: reject negative FixedNumber decimals#5130
Open
fuyua9 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FixedNumberdecimal counts before they reach fixed-point scaling helpersformatUnits,parseUnits,FixedNumber.fromValue, and object-formFixedNumber.fromStringformatsWhy
FixedNumberformats already reject decimals above 80, but object-form formats could still pass negative decimals through. That can produce confusing behavior in callers such as unit conversion, where a negative numeric unit is not a meaningful decimal count. This change makes negative decimals fail with the same argument-validation path used by other invalid fixed formats.Validation
npm cinpm run build -- --pretty false./node_modules/.bin/mocha --trace-warnings --reporter ./reporter.cjs ./lib.esm/_tests/test-utils-units.js --grep "negative decimal|bad unit conversion"