Skip to content

etchash: fix cache future item #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meowsbits merged 2 commits into from
Aug 31, 2022
Merged

etchash: fix cache future item #7

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7874e3e
etchash: fix cache future item
meowsbits Aug 31, 2022
2e3dc8f
fix comment syntax
meowsbits Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions etchash.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ func (lru *lru) get(epoch uint64, epochLength uint64, ecip1099FBlock *uint64) (i
}

// Update the 'future item' if epoch is larger than previously seen.
if epoch < maxEpoch-1 && lru.future < nextEpoch {
if epoch < maxEpoch-1 && lru.future != nextEpoch {
log.Trace("Requiring new future etchash "+lru.what, "epoch", nextEpoch)
future = lru.new(nextEpoch, nextEpochLength)
lru.future = nextEpoch
Expand Down Expand Up @@ -533,7 +533,7 @@ func (l *Light) getCache(blockNum uint64) *cache {
return c
}

/// dataset wraps an etchash dataset with some metadata to allow easier concurrent use.
// / dataset wraps an etchash dataset with some metadata to allow easier concurrent use.
Comment thread
meowsbits marked this conversation as resolved.
Outdated
type dataset struct {
epoch uint64 // Epoch for which this cache is relevant
epochLength uint64 // Epoch length (ECIP-1099)
Expand Down