docs: path can contain date patterns for filesink#2929
Open
danielnelson wants to merge 1 commit into
Open
Conversation
This was added as a review comment to the original change and wasn't included in the documentation. see estuary/connectors#3988
Member
|
@danielnelson looks good from a dev perspective. I think a review from @aeluce before merging is in order |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was added as a review comment to the original change and wasn't included in the documentation. Both the prefix and the path can use the date patterns.
see estuary/connectors#3988
Workflow steps:
None
Documentation links affected:
Notes for reviewers:
(anything that might help someone review this PR)