Support OS open-with calls on Windows & Linux - #2629
Merged
Conversation
Add support for providing file paths directly via CLI `chipmunk [Paths]` alongside the current CLI sub command based approach. This changes enable Chipmunk to respond to open-with call from OS correctly instead of returning with error. MacOS handle this case differently and may not work in this case. Also *.desktop has changed to provide a hint of the files supported by chipmunk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #2627
Add support for providing file paths directly via CLI
chipmunk [Paths]alongside the current CLI sub command-based approach.These changes enable Chipmunk to respond to open-with call from OS correctly instead of returning with error.
Also
*.desktophas changed to provide a hint of the files supported by chipmunk on Linux.MacOS handle this case differently and may not work in this case. I would skip the special handling of MacOS signals until it's really needed by our users