Send parsed attachments to UI in batches + Refactoring & Cleanup - #2626
Merged
Conversation
* Deliver the attachments of each parsed chunk with one call and one `AttachmentsUpdated` event instead of one per attachment. * Refactoring, cleaning up unused types and functions and adding docs.
Replace HashMap to save attachments in core with a vector as we are not using the lookup functionality on the map as we are creating a key on insert and forget about it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #2359
It includes:
AttachmentsUpdatedevent instead of one per attachment.