add new Kogan-Smarterhome-Smart-Power-Board-With-Usb-Ports-Energy-Meter#1506
Open
splitice wants to merge 5 commits intoesphome:mainfrom
Open
add new Kogan-Smarterhome-Smart-Power-Board-With-Usb-Ports-Energy-Meter#1506splitice wants to merge 5 commits intoesphome:mainfrom
splitice wants to merge 5 commits intoesphome:mainfrom
Conversation
✅ Deploy Preview for esphome-devices ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the existing Kogan SmarterHome smart power board device page to document a newer hardware revision (BK72xx/CB2S-based) and preserves the previous ESP8266-based revision under an “-Old” device page.
Changes:
- Update the main device page to new model KASPS30WACB with BK72xx/CB2S configuration and programming notes.
- Add an “-Old” device page containing the prior ESP8266 (KASPS10A3P3UA) documentation and image.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
| src/docs/devices/Kogan-Smarterhome-Smart-Power-Board-With-Usb-Ports-Energy-Meter/index.md | Updated to new model/revision with new flashing notes, pinout, and BK72xx YAML example. |
| src/docs/devices/Kogan-Smarterhome-Smart-Power-Board-With-Usb-Ports-Energy-Meter-Old/index.md | Added archived prior revision documentation and YAML example. |
| src/docs/devices/Kogan-Smarterhome-Smart-Power-Board-With-Usb-Ports-Energy-Meter-Old/kogan-smarterhome-smart-power-board-with-usb-ports-energy-meter.jpg | Added archived product image for the prior revision page. |
Comment on lines
+66
to
+72
| api: | ||
| reboot_timeout: 15min | ||
| encryption: | ||
| key: !secret encryption_key | ||
|
|
||
| ota: | ||
| password: !secret ota_password |
There was a problem hiding this comment.
This archived configuration includes secret references beyond the allowed WiFi secrets (e.g., !secret encryption_key and !secret ota_password). Device-page examples should not require secrets other than wifi_ssid/wifi_password; please remove these and present a config that can compile without extra secrets.
Author
There was a problem hiding this comment.
This guide can be deleted if deemed so. I've just archived it as is.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description of the changes
Technically this is a new revision, feel free to delete the old device. I am unsure if that model is worth keeping.
Type of changes
Checklist:
The only exceptions are
!secret wifi_ssidand!secret wifi_password.wifiorethernetblock has no static / manual ip address specified.A more involved example can be provided in a separate configuration block.