erts: support endian-aware port framing - #11441
Open
humdrum00001010 wants to merge 1 commit into
Open
Conversation
open_port/2 only supports big-endian packet headers, forcing callers of little- or native-endian protocols to implement framing in stream mode.
Add {packet,{N,Endian}} for two- and four-byte headers while preserving existing {packet,N} behavior.
|
|
Contributor
CT Test ResultsTests are running... https://github.com/erlang/otp/actions/runs/31325814313 Results for commit 38d5264 To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
open_port/2 only supports big-endian packet headers, forcing callers of little- or native-endian protocols to implement framing in raw mode.
Allow {packet, {N, Endian}} for two- and four-byte headers on spawned and file-descriptor ports while preserving existing {packet, N} behavior. The change covers the Unix and Windows drivers and includes documentation and regression tests.
Closes #11411