Cuddle epmd tests - #11427
Conversation
Our tests run epmd with a packet_timeout of 1 second, which causes our tests to fail more often now that we're less tolerant of slowloris-like behavior. This commit shortens the artificial delay accordingly.
jhogberg
added
team:VM
CT Test Results 2 files 12 suites 6m 40s ⏱️ Results for commit 79716a8. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
There was a problem hiding this comment.
Pull request overview
This PR updates the epmd_SUITE test helper protocol so its “slow write” behavior no longer exceeds the configured packet_timeout, reducing test flakiness after packet_timeout semantics changed from activity-based to packet-based.
Changes:
- Replaces
catchwithtry/catchinparse_line/1for clearer integer parsing error handling. - Shortens the artificial inter-byte delay in
slow_get_port_nr/1from 1s to 200ms pauses. - Updates the socket-send test helper to use
{pause, Milliseconds}instead of the legacyd/{d,S}delay spec.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Our tests run epmd with a
packet_timeoutof 1 second, which causes our tests to fail more often now that thepacket_timeoutis a packet timeout instead of an activity timeout. This commit shortens the artificial delay accordingly.