public_key: Compile ASN.1 modules serially for reproducible output - #11396
Open
bmwiedemann wants to merge 1 commit into
Open
public_key: Compile ASN.1 modules serially for reproducible output#11396bmwiedemann wants to merge 1 commit into
bmwiedemann wants to merge 1 commit into
Conversation
The ASN.1 compiler names anonymous parameterized-type/object-set arguments internal_object_set_argument_N using a global counter. How many instantiations run while checking a module depends on whether the checked .asn1db files of its imports already exist. The RFC 5912 modules import each other cyclically and the Makefile has no inter-module dependencies, so under make -jN the .asn1db availability is a race and atoms like getenc_internal_object_set_argument_2 vs _1 differ between builds. Serialize this directory to get a fixed order. Helps with issue erlang#4417 This patch was done while working on reproducible builds for openSUSE.
Contributor
CT Test Results 2 files 18 suites 4m 5s ⏱️ Results for commit 521670a. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ASN.1 compiler names anonymous parameterized-type/object-set arguments
internal_object_set_argument_Nusing a global counter. How many instantiations run while checking a module depends on whether the checked .asn1db files of its imports already exist. The RFC 5912 modules import each other cyclically and the Makefile has no inter-module dependencies, so under make -jN the .asn1db availability is a race and atoms likegetenc_internal_object_set_argument_2vs_1differ between builds. Serialize this directory to get a fixed order.Helps with issue #4417
This patch was done while working on reproducible builds for openSUSE.