stdlib: Use SOURCE_DATE_EPOCH for in-memory zip entries - #11394
Open
bmwiedemann wants to merge 1 commit into
Open
stdlib: Use SOURCE_DATE_EPOCH for in-memory zip entries#11394bmwiedemann wants to merge 1 commit into
bmwiedemann wants to merge 1 commit into
Conversation
zip:create/2,3 stamps entries created from in-memory binaries with the current local time. This makes every archive built from binaries, in particular escripts created by escript:create/2 and Elixir's mix escript.build (e.g. the rabbitmq-server escripts), unreproducible. Honor SOURCE_DATE_EPOCH when set. See https://reproducible-builds.org/ for why this is good and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of this variable. Helps with issue erlang#4417 This patch was done while working on reproducible builds for openSUSE.
bmwiedemann
force-pushed
the
reproduciblezip
branch
from
July 27, 2026 13:04
f31dd26 to
13da01c
Compare
Contributor
CT Test Results 2 files 100 suites 1h 6m 57s ⏱️ Results for commit 13da01c. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
Contributor
|
Thanks for the PR! However, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zip:create/2,3 stamps entries created from in-memory binaries with the current local time. This makes every archive built from binaries, in particular escripts created by escript:create/2 and Elixir's mix escript.build (e.g. the rabbitmq-server escripts), unreproducible. Honor
SOURCE_DATE_EPOCHwhen set.See https://reproducible-builds.org/ for why this is good and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of this variable.
Helps with issue #4417
This patch was done while working on reproducible builds for openSUSE.