Abort the install when an upgrade migration fails (#1497)#1498

Merged

erikdarlingdata merged 41 commits into

devfrom

feature/1497-addserverdialog-upgrade-abort

Jul 13, 2026

Commits on Jul 12, 2026

Abort the install when an upgrade migration fails (#1497)

erikdarlingdata
and
claude
committed
Add CHANGELOG entry for #1498

erikdarlingdata
and
claude
committed
Make the CLI abort on discovery failure; normalize SemVer suffixes

erikdarlingdata
and
claude
committed
Update CHANGELOG for the CLI abort and SemVer normalization

erikdarlingdata
and
claude
committed
Add a non-destructive repair path (Dashboard checkbox + CLI --repair)

erikdarlingdata
and
claude
committed
CHANGELOG: the non-destructive repair path

erikdarlingdata
and
claude
committed
Merge remote-tracking branch 'origin/dev' into feature/1497-addserverdialog-upgrade-abort
erikdarlingdata
committed
Block the install when version discovery fails; fix the repair-loop trap

erikdarlingdata
and
claude
committed
CHANGELOG: the discovery-failure guard

erikdarlingdata
and
claude
committed
Round 1 review: close the downgrade path my Connected_Current change opened

erikdarlingdata
and
claude
committed
Round 2 review: re-run the safety verdict, and stop awaiting in front of the guard

erikdarlingdata
and
claude
committed
Round 3 review: repair writes no history row; close the last two install doors

erikdarlingdata
and
claude
committed
Round 4 review: close the in-flight-detection door; stop the CLI lying about repair

erikdarlingdata
and
claude
committed
Round 5 review: stop the repair handoff swapping the user's credentials for sa

erikdarlingdata
and
claude
committed
Round 6: close the last stranding door, and the clean-install-behind-Repair state

erikdarlingdata
and
claude
committed
Round 7: the abort left the form dead, and my tests never ran in CI

erikdarlingdata
and
claude
committed
Round 8: the drop-the-database bug reopened itself, and one flag answered two questions

erikdarlingdata
and
claude
committed
Round 9: restore the state the FACTS imply, not the one we came from

erikdarlingdata
and
claude
committed
Round 9b: pin the fresh-install-vs-migrate decision in CI; move the sentinel out of the version space

erikdarlingdata
and
claude
committed
Round 10: make staleness unrenderable, instead of patching each consumer again

erikdarlingdata
and
claude
committed
Round 11: the structural guard was comparing the box to itself

erikdarlingdata
and
claude
committed
Round 12: an install must permanently supersede a detection in flight
erikdarlingdata
committed
Merge remote-tracking branch 'origin/dev' into feature/1497-addserverdialog-upgrade-abort
erikdarlingdata
committed
Round 13: fix the regression Round 12 introduced, and its two siblings
erikdarlingdata
committed
Round 13b: the handoff text outlived the run that produced it
erikdarlingdata
committed
Round 14: stop clearing the destructive ticks at each exit; clear them at the choke point
erikdarlingdata
committed
Round 15: the guard's own landing pad was the state it could not see
erikdarlingdata
committed
Round 17: a half-replaced fact does not merely evade the guard, it makes it AFFIRM
erikdarlingdata
committed
Round 18: the fix for the blank dialog was the same bug as the blank dialog
erikdarlingdata
committed
Round 19: Round 18 stopped the throw and not the write, and the throw was the signal
erikdarlingdata
committed
Round 20: hiding the install log on the one path that drops the database
erikdarlingdata
committed
CHANGELOG: the cancelled-edit rename and the hidden clean-install log
erikdarlingdata
committed
Round 21: "await is the only place this yields" was false, and I had leaned on it
erikdarlingdata
committed
Round 21b: the not-connected report is a status line, not a block
erikdarlingdata
committed
Round 22: cancelling a clean install came back looking like a completed one
erikdarlingdata
committed
CHANGELOG: the swallowed clean-install cancel, and the Save-on-no-database regression
erikdarlingdata
committed
Round 23: sanitize the report filename, and close the --repair/--uninstall hole
erikdarlingdata
committed
Round 23b: the file loop swallowed a cancel too, one method deeper than Round 22
erikdarlingdata
committed

Commits on Jul 13, 2026