fix: eliminate data race on application mode and reason fields#252
Open
Aliexe-code wants to merge 1 commit intoergo-services:masterfrom
Open
fix: eliminate data race on application mode and reason fields#252Aliexe-code wants to merge 1 commit intoergo-services:masterfrom
Aliexe-code wants to merge 1 commit intoergo-services:masterfrom
Conversation
|
|
Aliexe-code
force-pushed
the
fix/application-race-condition
branch
from
578f53c to
c789421
Compare
Fixes ergo-services#246 Changed mode from gen.ApplicationMode to int32 with atomic operations. Changed reason from error to atomic.Value for thread-safe access. This fixes the race between stop() and terminate() during shutdown. Also fixed race on state field in registerAppRoute() by using atomic load.
Aliexe-code
force-pushed
the
fix/application-race-condition
branch
from
c789421 to
5aa7518
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #246
Eliminates the data race between
application.stop()andapplication.terminate()during node shutdown by using atomic operations formodeandreasonfields.Changes
modefield fromgen.ApplicationModetoint32with atomic load/store operationsreasonfield fromerrortoatomic.Valuefor thread-safe accessstatefield inregisterAppRoute()by using atomic loadstart()to log mode after storing itRoot Cause
The race occurred because:
stop()writes tomodeandreasonterminate()reads these fields concurrently when child processes exit