Replace USD with CURRENCY_CODE in rp2_full_report.py#144
Conversation
The sheet Summary of the full report had "USD" currency code hard-coded in the headings. Replacing with reference to CURRENCY_CODE instead.
|
Sorry about the delay, can you update the tests as well? I think you just need to update the golden files to reflect the change perhaps. |
|
Hi @archont00 — thanks for this fix! While reviewing this PR we implemented the change along with unit tests verifying the header behavior for multiple non-USD currencies (EUR, GBP, JPY, CHF, CAD). The work is on this branch: The two relevant commits are:
You're welcome to cherry-pick from that branch if you'd like to add the tests to your PR. Alternatively, if you'd prefer, we can open a new PR that supersedes this one — whichever works best for you and @eprbell. I'll give you 2 weeks to respond and then I'll close this one down and supersede it. Generated by Claude Code |
The sheet Summary of the full report had "USD" currency code hard-coded in the headings. Replacing with reference to CURRENCY_CODE instead. Tested with rp2_generic plugin.