Skip to content

Per wallet application#138

Open
eprbell wants to merge 76 commits into
mainfrom
per_wallet_application
Open

Per wallet application#138
eprbell wants to merge 76 commits into
mainfrom
per_wallet_application

Conversation

@eprbell

@eprbell eprbell commented Jan 13, 2025

Copy link
Copy Markdown
Owner

Full implementation of per-wallet transfer analysis (discussed at #135) including comprehensive unit tests. This covers all the corner cases I was able to find. If you find a corner case that is not covered by a unit tests do let me know. Note that unit tests use Go style, table-driven format: this format is far superior to custom code and I think we should be using it for all new unit tests. Essentially it makes tests very easy to read and maintain: even non programmers could potentially read them and contribute ideas for new ones.

See an example of how to read and reason about RP2 Go-style unit tests here.

The code is essentially ready for review (except for a few minor lint issues).

@macanudo527

Copy link
Copy Markdown
Collaborator

@eprbell I know it is the holidays, but I thought I would get the ball rolling on this again. Is this about ready? Are there any major changes needed? I don't have that much time, but I can try to take a look at it here and there, so we can get this out for 2025 tax filing.

@eprbell

eprbell commented Jan 2, 2026

Copy link
Copy Markdown
Owner Author

@eprbell I know it is the holidays, but I thought I would get the ball rolling on this again. Is this about ready? Are there any major changes needed? I don't have that much time, but I can try to take a look at it here and there, so we can get this out for 2025 tax filing.

Hi @macanudo527, I just uploaded the latest development from 2025: it includes a good chunk of the global allocation logic (the transfer analysis logic was already checked in). It's still incomplete but that's how far I got. Unfortunately I don't have a lot of time to work on this right now, so I'm not sure how far I can get before Tax Day (if things change and I get more free time I'll let you know). Feel free to jump in, if you have time.

@eprbell

eprbell commented Feb 1, 2026

Copy link
Copy Markdown
Owner Author

I can confirm that unfortunately I won't have much time to work on this (and on RP2 in general) for the foreseeable future, due to heavy workload at my job. I don't think I'll be able to get any free cycles before Tax Day.

tobomobo added a commit to bitcoinaustria/rp2 that referenced this pull request Apr 21, 2026
Per-wallet application: draft integration from upstream PR eprbell#138
tobomobo added a commit to bitcoinaustria/rp2 that referenced this pull request Apr 21, 2026
README's per-wallet warnings were verbatim upstream and didn't mention
this fork's draft PR eprbell#138 integration or Austrian support. CHANGELOG
tracked phases 1-9 but not the (non-phase) per-wallet work from PR #1.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants