Skip to content

Added developer instructions to setup rp2 in a conda environment.#12

Open
stevendavis wants to merge 1 commit into
eprbell:mainfrom
stevendavis:readme-dev
Open

Added developer instructions to setup rp2 in a conda environment.#12
stevendavis wants to merge 1 commit into
eprbell:mainfrom
stevendavis:readme-dev

Conversation

@stevendavis

Copy link
Copy Markdown

Very simple 1st pull request, mostly to test the process and make sure everything is setup properly. Added developer instructions to setup rp2 in a conda environment.

@eprbell

eprbell commented Mar 10, 2022

Copy link
Copy Markdown
Owner

Thanks for the PR! Will add a few comments in the diff.

Comment thread README.dev.md
To setup RP2 in a conda environment, enter the following commands:
```
cd <rp2_directory>
conda create -n <env_name>

@eprbell eprbell Mar 10, 2022

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you missing instructions on Conda installation? Not sure about Windows (does Conda get installed by the the Python installer?), but I tried it on Mac and I got "conda: command not found"

Comment thread README.dev.md
```

#### Conda virtual environment
To setup RP2 in a conda environment, enter the following commands:

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uppercase Conda

Comment thread README.dev.md
#### Conda virtual environment
To setup RP2 in a conda environment, enter the following commands:
```
cd <rp2_directory>

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cd command is needed in the Python virtual environment section as well.

Comment thread README.dev.md
First make sure [Python](https://python.org) 3.7 or greater is installed (in the Python installer window be sure to click on "Add Python to PATH").

#### Python virtual environment
To setup RP2 in a python virtual environment, enter the following commands:

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you leave the reference to Powershell? I.e.: "open a PowerShell window and enter the following commands"

Comment thread README.dev.md
```

#### Conda virtual environment
To setup RP2 in a conda environment, enter the following commands:

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you leave the reference to Powershell? I.e.: "open a PowerShell window and enter the following commands"

Comment thread README.dev.md
First make sure [Python](https://python.org) 3.7 or greater is installed (in the Python installer window be sure to click on "Add Python to PATH"), then open a PowerShell window and enter the following commands:
First make sure [Python](https://python.org) 3.7 or greater is installed (in the Python installer window be sure to click on "Add Python to PATH").

#### Python virtual environment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This structure (Python vs Conda virtual env) would need to be duplicated in the Linux and Mac sections as well.

Comment thread README.dev.md
First make sure [Python](https://python.org) 3.7 or greater is installed (in the Python installer window be sure to click on "Add Python to PATH").

#### Python virtual environment
To setup RP2 in a python virtual environment, enter the following commands:

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uppercase Python.

@eprbell eprbell left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@stevendavis

Copy link
Copy Markdown
Author

Thinking about this a bit more....
Instead of embedding the Conda instructions within the Windows 10 section, maybe it would make more sense to have a single Conda install section after the list of operating systems, since the commands should be the same for every OS.

@eprbell

eprbell commented Mar 11, 2022

Copy link
Copy Markdown
Owner

How about this:

anlach pushed a commit to anlach/rp2 that referenced this pull request Mar 10, 2026
download data from coinbase in parallel & caching
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants