feat EPINIO-726: optional PVC deletion checkbox on app delete - #639
Open
psanghvi17 wants to merge 2 commits into
Open
feat EPINIO-726: optional PVC deletion checkbox on app delete#639psanghvi17 wants to merge 2 commits into
psanghvi17 wants to merge 2 commits into
Conversation
Expose Also delete PersistentVolumeClaims in app delete/bulk delete UI, default unchecked, and send deletePVC to the API (EPINIO-726).
Replace outdated epinio.growl.deleteApp.* keys with epinio.growl.application.delete.* in dashboard/pkg/epinio/components/application/AppDeleteModal.vue. Updates both success and error growl title/message keys (error message retains interpolation of the error text). Aligns code with the renamed translation keys so correct localized messages are shown after app deletion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #EPINIO-726
Add an optional “Also delete PersistentVolumeClaims” checkbox (default unchecked) on application delete / bulk delete, and send
deletePVCto the API.Depends on API PR: epinio/epinio#3103
Occurred changes and/or fixed issues
AppDeleteModal) and prompt-remove flow gain a PVC deletion checkbox, default off.showDeletePVCOptionand wires_deletePVConto selected apps.EpinioApplicationModel.removeand namespacedbulkRemoveincludedeletePVC: truein the delete body when opted in.epinio.growl.application.delete.*.Technical notes summary
_deleteImage/deleteImage).deletePVCfalse / unset).Areas or cases that should be tested
Browser used locally: Chromium/Chrome (reviewer please use Firefox or Edge).
Areas which could experience regressions
deleteImage/unbind/deletePVC).remove/bulkRemovewithout expecting the new body field.