fix EPINIO-716: show Rebuild for failed builds with reusable source - #638
Open
psanghvi17 wants to merge 2 commits into
Open
fix EPINIO-716: show Rebuild for failed builds with reusable source#638psanghvi17 wants to merge 2 commits into
psanghvi17 wants to merge 2 commits into
Conversation
Add canRetryBuild when git or blobuid is available, hide it for container image apps and while staging. restage uses async deploy when no deployment exists so failed builds can retry without a prior successful stage. Expose blobuid and stagingstatus on app types.
Show a Deploying badge instead of Unknown after staging succeeds, and keep restage disabled while deploy is still in progress.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #EPINIO-716
When a build fails, the applications table should show an error state (not
created), and users should be able to retry when source is still available. This UI change enables Rebuild when git or a storedblobuidis present, and uses async deploy for never-deployed / failed first pushes.Depends on API PR: epinio/epinio#3100
Occurred changes and/or fixed issues
canRetryBuild(git origin orblobuid), and disabled for container-image apps and while staging is active.restagenow runs async deploy with storedblobuid/ git origin instead of requiring a prior successfuldeployment.stage_id.blobuidandstagingstatusso the model can drive retry eligibility from the API.Technical notes summary
canRetryBuild: container URL → false; otherwise true whenorigin.gitorblobuidis present (covers SeaweedFS/S3 reuse for folder/archive uploads).retryDeployOriginnormalizes origin for async deploy without wiping source metadata when Kind is missing.waitAsyncDeployPhase; deployed path keepsstage()+waitForStaging.Areas or cases that should be tested
Browser used locally: Chromium/Chrome (reviewer please use Firefox or Edge).
blobuid.blobuid: Rebuild disabled / clear error if attempted.errorvscreatedvsbuildingvsrunning.stage_idis present.Areas which could experience regressions
waitAsyncDeployPhase/ensureAsyncDeployStarted.deployment.stage_idexists.