Skip to content

tophat conflicts with gcc@6: #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmsds merged 2 commits into from
May 9, 2019
Merged

tophat conflicts with gcc@6: #234

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1db815e
Fix tophat compilation with gcc@6:
rmsds May 7, 2019
bfc7093
Remove the patch and add conflict with gcc@6:
rmsds May 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions var/spack/repos/builtin/packages/tophat/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ class Tophat(AutotoolsPackage):
depends_on('boost@1.47:')
depends_on('bowtie2', type='run')

# uses make_pair which changed signature with C++14
# a patch exists: https://github.com/DaehwanKimLab/tophat/pull/38
# but there might be unexpected side effects
conflicts('%gcc@6:')

parallel = False

def configure_args(self):
Expand Down