Skip to content

fix(curriculum): include required prerequisites in personal learning scope - #113

Merged
enpasos merged 9 commits into
mainfrom
fix/personal-curriculum-prerequisite-closure
Nov 11, 2026
Merged

enpasos merged 9 commits into
mainfrom
fix/personal-curriculum-prerequisite-closure

Conversation

@enpasos

@enpasos enpasos commented Nov 10, 2026 •

Copy link
Copy Markdown
Owner

Required prerequisites could remain hidden support goals outside progress and completion. This implements the decision in #112: valid canonical seed atoms plus their complete atomic prerequisite closure form one fixed Personal Curriculum learning basis. Shared IDs count once, existing mastery remains satisfied, and focus uses canonical descendants intersected with that basis.

The learner API exposes required targets and their canonical witness paths, including foreign-subject prerequisites. The WebGUI preserves their navigation through course, jurisdiction and stage filters and supplies a preparation group for otherwise unplaced targets. Canonical cluster references retain their atomic descendants.

Incomplete Level 2 configurations can read historical mastery, export their durable results and clear obsolete focus without compiling an unresolved acquisition graph. Existing aliases and SRS overlays remain in the result-read path; nonempty learning-plan writes still require resolved configuration. Complete active configurations retain hard reference/cycle validation. Native, package, planning and OAuth regressions distinguish source eligibility, structural lookup and actual acquisition targets.

Validation:

  • Previously recorded selected compiler, runtime, controller and browser evidence remains in the pinned follow-up record; its older heads are not current full-CI acceptance.
  • The 11 November targeted 21-case diagnostic passed 16 cases and exposed five remaining failures. Native Chemistry/Economics, planning, package projection, incomplete-plan controls and topology freshness passed. The Math counterexample now requires complete acquisition roles while retaining its actual missing-target negative controls and full coverage checks.
  • After correction, both real OAuth/MCP variants and the focus-widening regression pass. The export follow-up passes with the actual database timestamp preserved (1 case, 105.221 seconds, bound sources unchanged). The updated Math method and full backend are not yet accepted.
  • Current repair head: bdae30d. Fresh mandatory remote CI is required. The four successful companion workflows on fa2bac5 are historical after this repair.

Canonical subject data and protected maturity floors are unchanged. Biology applicability/proof admission and the actual standard G17 milestone gate remain required separate deliveries.

@enpasos
enpasos marked this pull request as ready for review November 10, 2026 21:01
…um-prerequisite-closure

# Conflicts:
#	backend/src/test/java/com/skillpilot/backend/service/ProjectionRoleLearnerServiceTest.java
#	docs/concept/skill-graph/skillpilot-graph-definition.build.json
…t' into fix/personal-curriculum-prerequisite-closure

# Conflicts:
#	app/scripts/applicabilityCompiler.ts
@enpasos
enpasos merged commit cacf323 into main Nov 11, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant