Repository navigation
fix(curriculum): include required prerequisites in personal learning scope - #113
Merged
Merged
Conversation
enpasos
marked this pull request as ready for review
November 10, 2026 21:01
This was referenced Nov 10, 2026
…um-prerequisite-closure # Conflicts: # backend/src/test/java/com/skillpilot/backend/service/ProjectionRoleLearnerServiceTest.java # docs/concept/skill-graph/skillpilot-graph-definition.build.json
…t' into fix/personal-curriculum-prerequisite-closure # Conflicts: # app/scripts/applicabilityCompiler.ts
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required prerequisites could remain hidden support goals outside progress and completion. This implements the decision in #112: valid canonical seed atoms plus their complete atomic prerequisite closure form one fixed Personal Curriculum learning basis. Shared IDs count once, existing mastery remains satisfied, and focus uses canonical descendants intersected with that basis.
The learner API exposes required targets and their canonical witness paths, including foreign-subject prerequisites. The WebGUI preserves their navigation through course, jurisdiction and stage filters and supplies a preparation group for otherwise unplaced targets. Canonical cluster references retain their atomic descendants.
Incomplete Level 2 configurations can read historical mastery, export their durable results and clear obsolete focus without compiling an unresolved acquisition graph. Existing aliases and SRS overlays remain in the result-read path; nonempty learning-plan writes still require resolved configuration. Complete active configurations retain hard reference/cycle validation. Native, package, planning and OAuth regressions distinguish source eligibility, structural lookup and actual acquisition targets.
Validation:
Canonical subject data and protected maturity floors are unchanged. Biology applicability/proof admission and the actual standard G17 milestone gate remain required separate deliveries.