-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Implement support for specifying the httpcore Network Backend when creating default transports #3749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iciclespider
wants to merge
2
commits into
encode:master
Choose a base branch
from
iciclespider:network-backend
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+129
−0
Open
Implement support for specifying the httpcore Network Backend when creating default transports #3749
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,97 @@ | ||
| import typing | ||
|
|
||
| import httpcore | ||
| import pytest | ||
|
|
||
| import httpx | ||
|
|
||
|
|
||
| def test_network_backend(): | ||
| class Backend(httpcore.NetworkBackend): | ||
| def connect_tcp( | ||
| self, | ||
| host: str, | ||
| port: int, | ||
| timeout: typing.Optional[float] = None, | ||
| local_address: typing.Optional[str] = None, | ||
| socket_options: typing.Optional[ | ||
| typing.Iterable[httpcore.SOCKET_OPTION] | ||
| ] = None, | ||
| ) -> httpcore.NetworkStream: | ||
| return Stream() | ||
|
|
||
| class Stream(httpcore.NetworkStream): | ||
| body = b"\r\n".join( | ||
| [ | ||
| b"HTTP/1.1 200 OK", | ||
| b"", | ||
| b"From Backend!", | ||
| ] | ||
| ) | ||
|
|
||
| def read(self, max_bytes: int, timeout: typing.Optional[float] = None) -> bytes: | ||
| body = self.body | ||
| if body: | ||
| self.body = b"" | ||
| return body | ||
|
|
||
| def write(self, buffer: bytes, timeout: typing.Optional[float] = None) -> None: | ||
| pass | ||
|
|
||
| def close(self) -> None: | ||
| pass | ||
|
|
||
| backend = Backend() | ||
| transport = httpx.HTTPTransport(network_backend=backend) | ||
| with httpx.Client(transport=transport) as client: | ||
| response = client.get("http://www.example.org") | ||
| assert response.status_code == 200 | ||
| assert response.text == "From Backend!" | ||
|
|
||
|
|
||
| @pytest.mark.anyio | ||
| async def test_async_network_backend(): | ||
| class AsyncBackend(httpcore.AsyncNetworkBackend): | ||
| async def connect_tcp( | ||
| self, | ||
| host: str, | ||
| port: int, | ||
| timeout: typing.Optional[float] = None, | ||
| local_address: typing.Optional[str] = None, | ||
| socket_options: typing.Optional[ | ||
| typing.Iterable[httpcore.SOCKET_OPTION] | ||
| ] = None, | ||
| ) -> httpcore.AsyncNetworkStream: | ||
| return AsyncStream() | ||
|
|
||
| class AsyncStream(httpcore.AsyncNetworkStream): | ||
| body = b"\r\n".join( | ||
| [ | ||
| b"HTTP/1.1 200 OK", | ||
| b"", | ||
| b"From Async Backend!", | ||
| ] | ||
| ) | ||
|
|
||
| async def read( | ||
| self, max_bytes: int, timeout: typing.Optional[float] = None | ||
| ) -> bytes: | ||
| body = self.body | ||
| if body: | ||
| self.body = b"" | ||
| return body | ||
|
|
||
| async def write( | ||
| self, buffer: bytes, timeout: typing.Optional[float] = None | ||
| ) -> None: | ||
| pass | ||
|
|
||
| async def aclose(self) -> None: | ||
| pass | ||
|
|
||
| backend = AsyncBackend() | ||
| transport = httpx.AsyncHTTPTransport(network_backend=backend) | ||
| async with httpx.AsyncClient(transport=transport) as client: | ||
| response = await client.get("http://www.example.org") | ||
| assert response.status_code == 200 | ||
| assert response.text == "From Async Backend!" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://pypi.org/project/myk8s/
??
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was a theoretical package that returns a theoretical NetwokBackend.
Any suggestion for an alternative would be welcome.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the network backend examples to use httpcore.MockBackend.