Fix dup3 syscall to correctly handle flags and O_CLOEXEC#26724
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Apr 20, 2026
Merged
Fix dup3 syscall to correctly handle flags and O_CLOEXEC#26724sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
Collaborator
Author
|
The test duplication here makes me a bit sad, but there is already larger problem of resolving the wasmfs-test-split that happened during the development of wasmfs, and fixing that is outside the scope of this PR. |
kripken
approved these changes
Apr 20, 2026
- Added O_CLOEXEC support to __syscall_dup3 in JS filesystem. - Fixed flag validation in __syscall_dup3 in both JS and WasmFS. - Added dup3 and O_CLOEXEC test cases to existing dup tests. Fixes: emscripten-core#26703
This was referenced Apr 22, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #26703