Skip to content

Fix FIONREAD for pipes#26722

Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100:FIONREAD
Apr 21, 2026
Merged

Fix FIONREAD for pipes#26722
sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100:FIONREAD

Conversation

@sbc100
Copy link
Copy Markdown
Collaborator

@sbc100 sbc100 commented Apr 17, 2026

Fixes: #26711

@sbc100 sbc100 requested a review from hoodmane April 17, 2026 23:26
@sbc100 sbc100 requested a review from kripken April 17, 2026 23:27
@sbc100 sbc100 enabled auto-merge (squash) April 18, 2026 03:54
@sbc100 sbc100 force-pushed the FIONREAD branch 2 times, most recently from 0079b8e to e6c8449 Compare April 18, 2026 20:05
@sbc100 sbc100 requested a review from kleisauke April 18, 2026 23:00
@kleisauke
Copy link
Copy Markdown
Collaborator

Perhaps we should fix WasmFS while we're here too?:

// TODO: Full TTY support. For now this is limited, and matches the old FS.

return -EINVAL; // not supported

@sbc100
Copy link
Copy Markdown
Collaborator Author

sbc100 commented Apr 19, 2026

Perhaps we should fix WasmFS while we're here too?:

// TODO: Full TTY support. For now this is limited, and matches the old FS.

return -EINVAL; // not supported

Maybe, but given that the test in question is not yet running under wasmfs that seems like something that can be done a followup?

@kleisauke
Copy link
Copy Markdown
Collaborator

test_pipe_select is missing the @no_wasmfs decorator, so it ends up included in the wasmfs suite as wasmfs.test_pipe_select. Though, that suite is likely not executed in CI or by the emscripten-releases roller, so a follow-up sounds reasonable to me.

@sbc100
Copy link
Copy Markdown
Collaborator Author

sbc100 commented Apr 20, 2026

test_pipe_select is missing the @no_wasmfs decorator, so it ends up included in the wasmfs suite as wasmfs.test_pipe_select. Though, that suite is likely not executed in CI or by the emscripten-releases roller, so a follow-up sounds reasonable to me.

Ok, I fixed wasmfs.test_pipe_select and added it to CI

@sbc100 sbc100 merged commit 767c22c into emscripten-core:main Apr 21, 2026
29 checks passed
@sbc100 sbc100 deleted the FIONREAD branch April 21, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ioctl(pipe_fd, FIONREAD, &n) fails on pipe file descriptors

3 participants