Skip to content

Enable JSPI testing under firefox. NFC #26715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
Apr 18, 2026
+5 −3
Merged

Enable JSPI testing under firefox. NFC #26715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/firefox_user.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,3 +91,5 @@ user_pref("gfx.offscreencanvas.enabled", true);
user_pref("javascript.options.wasm_memory64", true);
// Do not ask user consent to enable audio playback (0: Allow autoplay for all media)
user_pref("media.autoplay.default", 0);
// Enable JSPI support
user_pref("javascript.options.wasm_js_promise_integration", true);
6 changes: 3 additions & 3 deletions test/test_browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,8 +274,8 @@ def setUpClass(cls):
print()

def require_jspi(self):
if not is_chrome():
self.skipTest(f'Current browser ({get_browser()}) does not support JSPI. Only chromium-based browsers ({CHROMIUM_BASED_BROWSERS}) support JSPI today.')
if not is_chrome() and not is_firefox():
self.skipTest(f'Current browser ({get_browser()}) does not support JSPI. Only chromium-based browsers ({CHROMIUM_BASED_BROWSERS}) and firefox support JSPI today.')
super().require_jspi()

def post_manual_reftest(self):
Expand Down Expand Up @@ -5332,7 +5332,7 @@ def test_wasmfs_fetch_backend_threaded(self, args):
})
@no_safari('TODO: Fails with abort:Assertion failed: err == 0') # Fails in Safari 17.6 (17618.3.11.11.7, 17618), Safari 26.0.1 (21622.1.22.11.15)
def test_wasmfs_opfs(self, args):
if '-sJSPI' in args:
if is_jspi(args):
self.require_jspi()
test = test_file('wasmfs/wasmfs_opfs.c')
args = ['-sWASMFS', '-O3'] + args
Expand Down
Loading