Skip to content

[WASM_WORKERS] Fix UB in pthread_mutex with debug+hybrid builds in pthread_mutex_unlock.c #26699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stephenduong1004 wants to merge 4 commits into
base: main
Choose a base branch
from
+9 −9
Open

[WASM_WORKERS] Fix UB in pthread_mutex with debug+hybrid builds in pthread_mutex_unlock.c #26699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4388f45
Update pthread_mutex_unlock.c
stephenduong1004 Apr 16, 2026
8758125
Update test_codesize_minimal_pthreads.json
stephenduong1004 Apr 16, 2026
337711c
Update test_codesize_minimal_pthreads_memgrowth.json
stephenduong1004 Apr 16, 2026
e4f586d
Merge pull request #1 from stephenduong1004/stephenduong1004-patch-1
stephenduong1004 Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion system/lib/libc/musl/src/thread/pthread_mutex_unlock.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ int __pthread_mutex_unlock(pthread_mutex_t *m)
self = __pthread_self();
old = m->_m_lock;
int own = old & 0x3fffffff;
if (own != self->tid)
if (own != CURRENT_THREAD_ID)
return EPERM;
if ((type&3) == PTHREAD_MUTEX_RECURSIVE && m->_m_count)
return m->_m_count--, 0;
Expand Down
8 changes: 4 additions & 4 deletions test/codesize/test_codesize_minimal_pthreads.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"a.out.js": 7367,
"a.out.js.gz": 3605,
"a.out.nodebug.wasm": 19095,
"a.out.nodebug.wasm.gz": 8830,
"total": 26462,
"total_gz": 12435,
"a.out.nodebug.wasm": 19097,
"a.out.nodebug.wasm.gz": 8828,
"total": 26464,
"total_gz": 12433,
"sent": [
"a (memory)",
"b (exit)",
Expand Down
8 changes: 4 additions & 4 deletions test/codesize/test_codesize_minimal_pthreads_memgrowth.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"a.out.js": 7769,
"a.out.js.gz": 3811,
"a.out.nodebug.wasm": 19096,
"a.out.nodebug.wasm.gz": 8831,
"total": 26865,
"total_gz": 12642,
"a.out.nodebug.wasm": 19098,
"a.out.nodebug.wasm.gz": 8829,
"total": 26867,
"total_gz": 12640,
"sent": [
"a (memory)",
"b (exit)",
Expand Down
Loading