Update mimalloc to 3.3.1 by kleisauke · Pull Request #26696 · emscripten-core/emscripten

kleisauke · 2026-04-16T08:30:21Z

Fixes: #23090.
Supersedes: #23037.
Supersedes: #24542.

See: llvm/llvm-project@ea58410

This reverts commit a4e07d4. In preparation for the next commit.

sbc100 · 2026-04-16T15:45:40Z


-This contains mimalloc 8c532c32c3c96e5ba1f2283e032f69ead8add00f (v2.1.7) with
+This contains mimalloc 0ddf397796fbefa35b3278bd4431c2913a9892eb (v3.3.0) with
 Emscripten-specific changes.


Are we tracking these emscripten-specific changes?

Was it easy enough for you to port them to the new version?

Emscripten-specific changes are tracked in commit 8f4d480, which was created via:

Replace system/lib/mimalloc/ with original mimalloc v2.1.7.

Commit those changes.

Upgrade to mimalloc v3.3.0.

Revert the changes from step 2.

Nice. I wonder if its worth forking mimalloc in the emscripten-core org like we do for llvm and musl in order to keep track of these changes.

Perhaps not worth it as the changes are so small and we have the option to upstream most of them (I think?)

It's probably not worth creating a fork for these small changes. The changes to src/prim/emscripten/prim.c could likely be upstreamed, but I'm less certain about those in ‎src/alloc-override.c (although commit microsoft/mimalloc@a9b895e introduced a similar Emscripten-specific change to that file). I attempted to revert those weak decls with commit a4e07d4 but it was needed for test_wrap_malloc_mimalloc.

Commit 9e64b24 may also qualify as an Emscripten-specific change, but I'm not sure whether it should be documented (I've opened PR microsoft/mimalloc#1264 for this).

sbc100 · 2026-04-16T15:46:18Z

@@ -8654,8 +8654,7 @@ def test_mallinfo(self):
  @parameterized({
    '': ([],),
    'emmalloc': (['-sMALLOC=emmalloc'],),
-    # FIXME(https://github.com/emscripten-core/emscripten/issues/23090)
-    # 'mimalloc': (['-sMALLOC=mimalloc'],),
+    'mimalloc': (['-sMALLOC=mimalloc', '-sABORTING_MALLOC=0'],),


Why is ABORTING_MALLOC=0 needed here bit not for the other variants of this test?

It was somehow necessary for wasm64_4gb.test_wrap_malloc_mimalloc. mimalloc was likely over-allocating internally, and this change prevented an abort().

Maybe worth a TODO to investigate?

Added a TODO comment with dcf3cfd.

sbc100 · 2026-04-16T15:48:23Z

+    '-DMI_MAX_ALIGN_SIZE=8',
+    # reserve memory in 64 MiB chunks (internally divided by 4)
+    # Note: keep in sync with the -sINITIAL_HEAP default
+    '-DMI_DEFAULT_ARENA_RESERVE=65536',


Is this number if kb ?

It's in KiB.

emscripten/system/lib/mimalloc/src/options.c

Line 148 in 094d31e

{ MI_DEFAULT_ARENA_RESERVE, MI_OPTION_UNINIT, MI_OPTION(arena_reserve) }, // reserve memory N KiB at a time (=1GiB) (use `option_get_size`)

emscripten/system/lib/mimalloc/include/mimalloc.h

Line 463 in 094d31e

mi_option_arena_reserve, // initial memory size for arena reservation (= 1 GiB on 64-bit) (internally, this value is in KiB; use `mi_option_get_size`)

The / 4 happens here:

emscripten/system/lib/mimalloc/src/arena.c

Lines 319 to 321 in 094d31e

if (!_mi_os_has_virtual_reserve()) {

arena_reserve = arena_reserve/4; // be conservative if virtual reserve is not supported (for WASM for example)

}

The size is indeed in Kb (confusing, but it is to avoid overflow on the long options for large reservations). So, it would reserve 64 MiB generally, but eventually actually reserve 16 MiB at a time since wasm doesn't have virtual reserve.

sbc100 · 2026-04-16T15:50:07Z

    # build mimalloc with an override of malloc/free
    '-DMI_MALLOC_OVERRIDE',
    # TODO: add build modes that include debug checks 1,2,3
    '-DMI_DEBUG=0',
    # disable `assert()` in the underlying emmalloc allocator
    '-DNDEBUG',
-    # avoid use of `__builtin_thread_pointer()`
-    '-DMI_LIBC_MUSL',


We are using musl so wouldn't we want to continue to define this?

The MI_LIBC_MUSL definition is only used by:

emscripten/system/lib/mimalloc/include/mimalloc/prim.h

Lines 252 to 265 in 094d31e

// Do we have __builtin_thread_pointer? This would be the preferred way to get a unique thread id

// but unfortunately, it seems we cannot test for this reliably at this time (see issue #883)

// Nevertheless, it seems needed on older graviton platforms (see issue #851).

// For now, we only enable this for specific platforms.

#if !defined(__APPLE__) /* on apple (M1) the wrong register is read (tpidr_el0 instead of tpidrro_el0) so fall back to TLS slot assembly (<https://github.com/microsoft/mimalloc/issues/343#issuecomment-763272369>)*/ \

&& !defined(__CYGWIN__) \

&& !defined(MI_LIBC_MUSL) \

&& (!defined(__clang_major__) || __clang_major__ >= 14) /* older clang versions emit bad code; fall back to using the TLS slot (<https://lore.kernel.org/linux-arm-kernel/202110280952.352F66D8@keescook/T/>) */

#if (defined(__GNUC__) && (__GNUC__ >= 7) && defined(__aarch64__)) /* aarch64 for older gcc versions (issue #851) */ \

|| (defined(__GNUC__) && (__GNUC__ >= 11) && defined(__x86_64__)) \

|| (defined(__clang_major__) && (__clang_major__ >= 14) && (defined(__aarch64__) || defined(__x86_64__)))

#define MI_USE_BUILTIN_THREAD_POINTER 1

#endif

#endif

Looking at commit microsoft/mimalloc@e46c114 and the linked issue, I don't think it applies to Emscripten.

I will add a check for #ifndef MI_USE_BUILTIN_THREAD_POINTER -- that way you could keep -DMI_LIBC_MUSL and add -DMI_USE_BUILTIN_THREAD_POINTER=1 . Would that work for you?
Unfortunately, the builtin_thread_pointer support is hard to detect reliably so it is hard to avoid these kind of elaborate checks :-(

Great! I re-added -DMI_LIBC_MUSL with commit 3841eab.

sbc100 · 2026-04-16T17:25:02Z

Thanks for working on this!

Lgtm but let's wait for @kripken to chime in

…ipten-core/emscripten#26696)

daanx · 2026-04-20T21:01:42Z

FYI: I just released v3.3.1 which has the fixes I suggested above.

This reverts commit 9e64b24.

This reverts commit 8f4d480.

This reverts commit c3500f1.

To ensure the internal `_emscripten_yield()` function is called.

kleisauke · 2026-04-21T08:10:13Z

The latest revision of this PR updates mimalloc to v3.3.1.

sbc100 · 2026-04-21T14:30:18Z

Lgtm. @kripken can you take a look?

kripken

Great, thanks! Diff looks as expected.

daanx · 2026-04-21T17:46:08Z

I added sched_yield() to mimalloc's dev3 as well.

sbc100

Ok, this should be good to land whenever you like @kleisauke.

(BTW we tend to use Fixes: #XX in our PR descriptions rather then Resolves:)

kleisauke · 2026-04-21T17:57:13Z

Thanks all! :)

kleisauke added 7 commits April 16, 2026 10:16

Update mimalloc to 3.3.0 (microsoft/mimalloc@0ddf397)

ee253d1

mimalloc: add Emscripten-specific changes

8f4d480

mimalloc: enable use of __builtin_thread_pointer()

57a6623

See: llvm/llvm-project@ea58410

mimalloc: remove weak decls

a4e07d4

mimalloc: disable large pages by default

0719860

mimalloc: halve the page size

6b83c90

mimalloc: ensure proper alignment

a8cb678

This was referenced Apr 16, 2026

[mimalloc] Halve the page size #23037

Closed

Update mimalloc to 2.2.4 #24542

Closed

[do not merge] Test suite with mimalloc #24539

Draft

mimalloc: fix single-threaded build

9e64b24

kleisauke mentioned this pull request Apr 16, 2026

Fix single-threaded Wasm build microsoft/mimalloc#1264

Merged

kleisauke added 6 commits April 16, 2026 12:25

Rebaseline other.test_malloc_size_mimalloc* codesize expectations

ddd3840

Revert "mimalloc: remove weak decls"

02d918b

This reverts commit a4e07d4. In preparation for the next commit.

Fix test_wrap_malloc_mimalloc

23f8935

Update ChangeLog.md

0158c62

Fix wasm64_4gb.test_wrap_malloc_mimalloc

9607089

Revise commit 23f8935 and 9607089

094d31e

Resolves: emscripten-core#23090.

kleisauke mentioned this pull request Apr 16, 2026

test_wrap_malloc currently failed under mimalloc #23090

Closed

sbc100 reviewed Apr 16, 2026

View reviewed changes

Comment thread tools/system_libs.py

sbc100 reviewed Apr 16, 2026

View reviewed changes

kleisauke added 2 commits April 16, 2026 18:39

Merge branch 'main' into mimalloc-update-3.3.0

4207b4f

Add TODO comment

dcf3cfd

daanx added a commit to microsoft/mimalloc that referenced this pull request Apr 17, 2026

allow user override of MI_USE_BUILTIN_THREAD_POINTER (see issue emscr…

457c2f9

…ipten-core/emscripten#26696)

kleisauke added 3 commits April 21, 2026 09:20

Merge branch 'main' into mimalloc-update-3.3.0

189f8c2

Revert "mimalloc: fix single-threaded build"

29b4db0

This reverts commit 9e64b24.

Revert "mimalloc: add Emscripten-specific changes"

c3500f1

This reverts commit 8f4d480.

kleisauke added 6 commits April 21, 2026 09:25

Update mimalloc to 3.3.1 (microsoft/mimalloc@e2e6e70)

eac5118

Reapply "mimalloc: add Emscripten-specific changes"

8c9a3d6

This reverts commit c3500f1.

mimalloc: re-add MI_LIBC_MUSL definition

3841eab

mimalloc: fix multithreaded build

924cfeb

mimalloc: implement _mi_prim_thread_yield() using sched_yield()

431ed8e

To ensure the internal `_emscripten_yield()` function is called.

Update ChangeLog.md

2e94b9b

kleisauke changed the title ~~Update mimalloc to 3.3.0~~ Update mimalloc to 3.3.1 Apr 21, 2026

kleisauke mentioned this pull request Apr 21, 2026

Emscripten: add missing include for getentropy() microsoft/mimalloc#1280

Merged

IWYU for sched_yield() - see 431ed8e

5f1977b

kripken approved these changes Apr 21, 2026

View reviewed changes

sbc100 reviewed Apr 21, 2026

View reviewed changes

kleisauke merged commit 10f62b4 into emscripten-core:main Apr 21, 2026
29 checks passed

kleisauke deleted the mimalloc-update-3.3.0 branch April 21, 2026 17:58

juj mentioned this pull request Apr 21, 2026

core2s.test_wrap_malloc_mimalloc failure #26742

Closed

This was referenced Apr 22, 2026

gha test #26746

Draft

Update test_duration in parallel testsuite #26804

Open

	if (!_mi_os_has_virtual_reserve()) {
	arena_reserve = arena_reserve/4; // be conservative if virtual reserve is not supported (for WASM for example)
	}

	// Do we have __builtin_thread_pointer? This would be the preferred way to get a unique thread id
	// but unfortunately, it seems we cannot test for this reliably at this time (see issue #883)
	// Nevertheless, it seems needed on older graviton platforms (see issue #851).
	// For now, we only enable this for specific platforms.
	#if !defined(__APPLE__) /* on apple (M1) the wrong register is read (tpidr_el0 instead of tpidrro_el0) so fall back to TLS slot assembly (<https://github.com/microsoft/mimalloc/issues/343#issuecomment-763272369>)*/ \
	&& !defined(__CYGWIN__) \
	&& !defined(MI_LIBC_MUSL) \
	&& (!defined(__clang_major__) \|\| __clang_major__ >= 14) /* older clang versions emit bad code; fall back to using the TLS slot (<https://lore.kernel.org/linux-arm-kernel/202110280952.352F66D8@keescook/T/>) */
	#if (defined(__GNUC__) && (__GNUC__ >= 7) && defined(__aarch64__)) /* aarch64 for older gcc versions (issue #851) */ \
	\|\| (defined(__GNUC__) && (__GNUC__ >= 11) && defined(__x86_64__)) \
	\|\| (defined(__clang_major__) && (__clang_major__ >= 14) && (defined(__aarch64__) \|\| defined(__x86_64__)))
	#define MI_USE_BUILTIN_THREAD_POINTER 1
	#endif
	#endif

Conversation

kleisauke commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sbc100 commented Apr 16, 2026

Uh oh!

daanx commented Apr 20, 2026

Uh oh!

kleisauke commented Apr 21, 2026

Uh oh!

sbc100 commented Apr 21, 2026

Uh oh!

kripken left a comment

Choose a reason for hiding this comment

Uh oh!

daanx commented Apr 21, 2026

Uh oh!

sbc100 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kleisauke commented Apr 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kleisauke commented Apr 16, 2026 •

edited

Loading