Fix wrap-around month logic in calendar_tostringlist#92
Merged
Conversation
For year-wrapping calendar intervals like "12-2" (Dec-Feb), the else
branch matched months 2-12 instead of {12, 1, 2} -- the complement of
the intended set. Plants with winter blooming/fruiting periods (e.g.
Coffea arabica fruiting 12-2, Cymbidium cochleare blooming 12-1)
displayed the wrong months in their calendar widget.
Use OR instead of AND so the wrap-around branch covers months >= first
or <= second.
Owner
|
Yes that was wrong... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For year-wrapping calendar intervals like "12-2" (Dec-Feb), the else
branch matched months 2-12 instead of {12, 1, 2} -- the complement of
the intended set. Plants with winter blooming/fruiting periods (e.g.
Coffea arabica fruiting 12-2, Cymbidium cochleare blooming 12-1)
displayed the wrong months in their calendar widget.
Use OR instead of AND so the wrap-around branch covers months >= first
or <= second.