Allowed end-developers to install @embroider/try#8
Closed
ijlee2 wants to merge 1 commit intoembroider-build:mainfrom
Closed
Allowed end-developers to install @embroider/try#8ijlee2 wants to merge 1 commit intoembroider-build:mainfrom
ijlee2 wants to merge 1 commit intoembroider-build:mainfrom
Conversation
|
I think if installed, |
Author
Yep, I checked this in ijlee2/ember-container-query@2163b14. I had misunderstood how |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The
READMEforv1.0.1claims that one can runpnpm @embroider/try, but this isn't possible (to my knowledge) due to the package name starting with@.By providing an alias, we can provide end-developers the option to install
@embroider/tryin a package as a development dependency. (That is, they can fix the version and don't have to use npx, pnpx, etc.)