Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ function rewriteKeyword(
) {
if (env.meta?.jsutils) {
node.original = env.meta.jsutils.bindImport(moduleSpecifier, name, node, {
name,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turns out "name" isn't a thing

nameHint: `__keyword__${name}`,
});
} else if (env.meta?.emberRuntime) {
node.original = env.meta.emberRuntime.lookupKeyword(name);
Expand Down
33 changes: 33 additions & 0 deletions smoke-tests/scenarios/basic-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,39 @@ function basicTest(scenarios: Scenarios, appName: string) {
});
});
`,
'lte-js-scope-polution-test.gjs': `
import { module, test } from 'qunit';
import { setupRenderingTest } from 'ember-qunit';
import { render } from '@ember/test-helpers';

module('Using {{lte}} in a template should not bleed into outer javascript scope', function(hooks) {
setupRenderingTest(hooks);

test('it works - but it should not', async function(assert) {
let a = 1;
let b = 2;

function localLteHelper() {
try {
// this should not be define because it is not imported
return lte(...arguments);
} catch {
return 'WE COULD NOT FIND IT'
}
}

await render(
<template>
<span data-local-lte>{{localLteHelper a b}}</span>
<span data-lte>{{lte a a}}</span>
</template>
);

assert.dom('[data-local-lte]').hasText('WE COULD NOT FIND IT');
assert.dom('[data-lte]').hasText('true');
});
});
`,
'lt-lte-gt-gte-as-keyword-test.gjs': `
import { module, test } from 'qunit';
import { setupRenderingTest } from 'ember-qunit';
Expand Down
Loading