Skip to content

fix: make VERSION match package.json - #108

Merged
luwes merged 1 commit into
masterfrom
fix/version-from-package
Nov 3, 2026
Merged

luwes merged 1 commit into
masterfrom
fix/version-from-package

Conversation

@luwes

@luwes luwes commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator

playerjs.VERSION was still 0.0.11 while package.json says 0.1.0, so every message advertised the wrong version.

  • src/core.js: VERSION is now 0.1.0.
  • e2e/protocol.spec.ts: the wire-format tests read the expected version from package.json instead of hardcoding it, and the test.fail() for this bug is now a regular test. Bumping package.json without updating VERSION, or the other way round, now fails CI. I checked this by bumping only package.json, which failed 5 tests.

When the new build is in place it can inject the version from package.json, so VERSION won't need editing by hand.

Receivers that read version from messages will now see 0.1.0. Nothing in the library branches on it.

Closes #57

playerjs.VERSION was still 0.0.11 while package.json says 0.1.0, so every
message advertised the wrong version (#57).

Set it to 0.1.0 and make the protocol tests read the expected version from
package.json, so bumping one without the other fails CI. The new build can
inject it from package.json later.
@luwes
luwes merged commit f44d726 into master Nov 3, 2026
1 check passed
@luwes
luwes deleted the fix/version-from-package branch November 3, 2026 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

playerjs.VERSION does not match pacakge version

1 participant