Repository navigation
fix: make VERSION match package.json - #108
Merged
Merged
Conversation
playerjs.VERSION was still 0.0.11 while package.json says 0.1.0, so every message advertised the wrong version (#57). Set it to 0.1.0 and make the protocol tests read the expected version from package.json, so bumping one without the other fails CI. The new build can inject it from package.json later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
playerjs.VERSIONwas still0.0.11whilepackage.jsonsays0.1.0, so every message advertised the wrong version.src/core.js:VERSIONis now0.1.0.e2e/protocol.spec.ts: the wire-format tests read the expected version frompackage.jsoninstead of hardcoding it, and thetest.fail()for this bug is now a regular test. Bumpingpackage.jsonwithout updatingVERSION, or the other way round, now fails CI. I checked this by bumping onlypackage.json, which failed 5 tests.When the new build is in place it can inject the version from
package.json, soVERSIONwon't need editing by hand.Receivers that read
versionfrom messages will now see0.1.0. Nothing in the library branches on it.Closes #57