Streaming review - #1864
Conversation
igordayen
left a comment
There was a problem hiding this comment.
@arnabnandy7 - thanks for addressing generate stream with thinking.
few comments to consider.
KDOC with examples could be helpful.
Performance test would be awesome, what is the avg overhead.
Thanks
0f53a88 to
8dcca17
Compare
|
@igordayen I've implemented all requested review changes:
Verification: Performance across two warmed 30-run samples: |
igordayen
left a comment
There was a problem hiding this comment.
@arnabnandy7 - requesting changes reletated to documenting algorithm and reusability. the code is SO critical that readability should be addressed 100%.
Thanks for understanding.
Regards, Igor
8dcca17 to
79fec8f
Compare
|
Will be working on a simple yet practical solution post 1.5.0 with full code reusability from the blocking thinking path. Also, in the output, Appreciate if you please keep dev on hold, thanks. |
Signed-off-by: King Star <mcxin.y@gmail.com>
Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
79fec8f to
0c93d19
Compare
Part of review fixes for PR #1819