Upgrade to jackson3 - #76
Open
guanxuc wants to merge 1 commit into
Open
Conversation
Signed-off-by: guanxu <1510424541@qq.com>
igordayen
approved these changes
Aug 3, 2026
jimador
requested changes
Aug 7, 2026
jimador
left a comment
jimador
left a comment
Collaborator
There was a problem hiding this comment.
Looks great! Thank you. Just a couple of house keeping comments for existing clients.
| import org.springframework.http.ResponseEntity | ||
| import org.springframework.web.bind.annotation.* | ||
| import org.springframework.web.multipart.MultipartFile | ||
| import tools.jackson.databind.ObjectMapper |
Collaborator
There was a problem hiding this comment.
Can we verify that existing consumers can still start and use Dice JSON with Jackson 2 on the classpath? If not, this needs a compatibility period before changing the public ObjectMapper type.
| class PropositionJacksonRoundTripTest { | ||
|
|
||
| private val mapper = jacksonObjectMapper().findAndRegisterModules() | ||
| private val mapper = jacksonObjectMapper() |
Collaborator
There was a problem hiding this comment.
Can we add a JSON fixture written by the Jackson 2 repository and load it here? This only tests a Jackson 3 round trip, so it does not cover existing persisted data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.