feat: Add LSP 3.17 InlayHint features (resolve, textEdits, label parts)#4995
Open
takeokunn wants to merge 1 commit into
Open
feat: Add LSP 3.17 InlayHint features (resolve, textEdits, label parts)#4995takeokunn wants to merge 1 commit into
takeokunn wants to merge 1 commit into
Conversation
…solve - Implement InlayHint features: textEdits, tooltip, data, label parts - Add per-part tooltip/location/command, inlayHint/resolve, mouse handler - Introduce lsp-inlay-hint-accept command for interactive hint acceptance - Update protocol definitions and server mock for new capabilities - Enhance tests for overlay data, label parts, and mouse keymap interaction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends lsp-mode's InlayHint support with LSP 3.17 specification features, addressing #4775.
inlayHint/resolvesupport withresolveSupportcapability advertisement fortextEditsandtooltiplsp-inlay-hint-acceptinteractive command that applies a hint'stextEdits(resolving lazily viainlayHint/resolveif needed)InlayHintLabelPartrendering with per-parttooltip,location(click-to-navigate), andcommand(click-to-execute)tooltipanddatafield support onInlayHinttype:cancel-tokento prevent stale async request accumulationChanges
lsp-mode.ellsp-inlay-hint-accept,lsp--inlay-hint-resolve,lsp--inlay-hint-mouse-handler,lsp--inlay-hint-label-part-string,lsp--inlay-hint-tooltip-text), capability registration,s-l a i)lsp-protocol.elInlayHintOptionstype; extendInlayHintwith:textEdits :tooltip :data; addInlayHintLabelPartwith:tooltip :location :commandtest/lsp-mock-server-test.eltest/mock-lsp-server.elresolveProviderin mock server capabilitiesCHANGELOG.orgTest plan
lsp-mock-server-inlay-hint-stores-data,lsp-mock-server-inlay-hint-label-parts,lsp-mock-server-inlay-hint-has-keymap)lsp-inlay-hints-mode, verify hints render with tooltipslsp-inlay-hint-accepton hint with textEdits → edits appliedlsp-inlay-hint-accepton hint without textEdits → resolves viainlayHint/resolve