Skip to content

Improve lsp--buffer-string-visible performance, avoide headvy generate-new-buffer#4794

Open
eval-exec wants to merge 1 commit into
emacs-lsp:masterfrom
eval-exec:exec/improve-lsp--buffer-string-visible-performance
Open

Improve lsp--buffer-string-visible performance, avoide headvy generate-new-buffer#4794
eval-exec wants to merge 1 commit into
emacs-lsp:masterfrom
eval-exec:exec/improve-lsp--buffer-string-visible-performance

Conversation

@eval-exec
Copy link
Copy Markdown
Contributor

  • I added a new entry to CHANGELOG.md

  • I updated documentation if applicable (docs folder)

…e-new-buffer

Signed-off-by: Eval EXEC <execvy@gmail.com>
@eval-exec eval-exec force-pushed the exec/improve-lsp--buffer-string-visible-performance branch from 3ab1722 to 2aa37ec Compare May 24, 2025 09:13
@eval-exec eval-exec marked this pull request as ready for review May 24, 2025 09:14
@kiennq
Copy link
Copy Markdown
Member

kiennq commented May 26, 2025

Do you have a benchmark for the perf improvement?
I think the concat is degrading the performance more than insert + generate-new-buffer though. A nit performance improvement over the current code is passing inhibit-hooks for generate-new-buffer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants