Add configuration for grep-edit-mode - #944
Open
hiecaq wants to merge 1 commit into
Open
Conversation
jojojames
reviewed
Sep 5, 2026
|
|
||
| ;; `wgrep' integration | ||
| (when (fboundp 'wgrep-setup) | ||
| (cond |
Collaborator
There was a problem hiding this comment.
Is it possible to use both wgrep and grep-edit-mode in the same emacs session?
Contributor
Author
There was a problem hiding this comment.
Technically yes, they implement a similar grep-mode <-> editable grep-mode behavior. But I believe the reason most people installed wgrep is for this editing grep result feature, which precedes grep-edit-mode by far (as it implements atomic updates, could be reverted, etc). The most benefit of grep-edit-mode is that it's built-in, so I consider it as a fallback as for now.
Collaborator
There was a problem hiding this comment.
Lets split them then. I use wgrep most with dired, not grep.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of what the package does
grep-edit-mode is Emacs 31's built-in alternative to wgrep. Wgrep is more feature-complete, so I bind it as a fallback when wgrep is not available.
Direct link to the package repository
https://github.com/emacs-mirror/emacs/blob/emacs-31/lisp/progmodes/grep.el#L1125
Checklist
Assume you're working on
mpcmode:M-x checkdocis happy. Don't manually write(provide 'evil-collection-mpc),M-x checkdoccan do it automatically for youevil-collection-mpc-setupwithdefunevil-collection-mpc-mode-mapswithdefconstevil-collection-mpc-