Skip to content

Drop expo-modules-jsi local patch in favor of 57.0.5 - #971

Merged
kraenhansen merged 2 commits into
mainfrom
cursor/drop-expo-modules-jsi-patch-957
Aug 22, 2026
Merged

Drop expo-modules-jsi local patch in favor of 57.0.5#971
kraenhansen merged 2 commits into
mainfrom
cursor/drop-expo-modules-jsi-patch-957

Conversation

@cursor

@cursor cursor Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #957 by removing the temporary expo-modules-jsi@57.0.4 pnpm patch now that upstream 57.0.5 includes the dateFromMilliseconds / Double.magnitude fix from expo/expo#49039.

Details

  • Delete patches/expo-modules-jsi@57.0.4.patch and the matching pnpm.patchedDependencies entry
  • Resolve expo-modules-jsi@57.0.5 in the lockfile (no patch)
  • Temporarily add expo-modules-jsi to minimumReleaseAgeExclude until 2026-08-27T10:47:33Z (when 57.0.5 matures under the repo’s 7-day minimumReleaseAge)
  • Leave the @config-plugins/react-native-webrtc exclude in place (still needed until 2026-08-22)

No published package API change; no changeset.

Test plan

  • pnpm install succeeds
  • Lockfile shows expo-modules-jsi@57.0.5 without patch_hash
  • Installed tarball contains milliseconds.magnitude

cc @kraenhansen — please review.

Open in Web View Automation 

Upstream expo-modules-jsi@57.0.5 includes the dateFromMilliseconds
Double.magnitude fix from expo/expo#49039, so the local pnpm patch is
no longer needed. Temporarily exclude the package from minimumReleaseAge
until 2026-08-27T10:47:33Z when 57.0.5 matures.
@cursor
cursor Bot requested a review from kraenhansen August 21, 2026 07:09
@kraenhansen
kraenhansen marked this pull request as ready for review August 21, 2026 07:12
@cursor

cursor Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

PR Summary

Low Risk
Dependency-only change: drops a local patch in favor of a published Expo patch release. Temporarily bypasses minimumReleaseAge for this package until it is 7 days old.

Overview
Removes the local expo-modules-jsi@57.0.4 pnpm patch now that upstream 57.0.5 includes the dateFromMilliseconds / Double.magnitude fix.

The patch file and patchedDependencies entry are gone; the lockfile resolves unpatched 57.0.5. expo-modules-jsi is temporarily added to minimumReleaseAgeExclude until 2026-08-27 so the 7-day supply-chain age gate does not block it.

Reviewed by Cursor Bugbot for commit 3253bea. Bugbot is set up for automated code reviews on this repo. Configure here.

Keep #971 current with main while awaiting merge of the expo-modules-jsi patch drop.

Co-authored-by: Kræn Hansen <mail@kraenhansen.dk>
@cursor
cursor Bot requested a review from kraenhansen August 22, 2026 07:07
@kraenhansen
kraenhansen merged commit 2a9057e into main Aug 22, 2026
4 checks passed
@kraenhansen
kraenhansen deleted the cursor/drop-expo-modules-jsi-patch-957 branch August 22, 2026 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop expo-modules-jsi patch once upstream dateFromMilliseconds fix is released

2 participants