Drop expo-modules-jsi local patch in favor of 57.0.5 - #971
Merged
Conversation
Upstream expo-modules-jsi@57.0.5 includes the dateFromMilliseconds Double.magnitude fix from expo/expo#49039, so the local pnpm patch is no longer needed. Temporarily exclude the package from minimumReleaseAge until 2026-08-27T10:47:33Z when 57.0.5 matures.
kraenhansen
approved these changes
Aug 21, 2026
kraenhansen
marked this pull request as ready for review
August 21, 2026 07:12
Contributor
Author
PR SummaryLow Risk Overview The patch file and Reviewed by Cursor Bugbot for commit 3253bea. Bugbot is set up for automated code reviews on this repo. Configure here. |
Keep #971 current with main while awaiting merge of the expo-modules-jsi patch drop. Co-authored-by: Kræn Hansen <mail@kraenhansen.dk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #957 by removing the temporary
expo-modules-jsi@57.0.4pnpm patch now that upstream57.0.5includes thedateFromMilliseconds/Double.magnitudefix from expo/expo#49039.Details
patches/expo-modules-jsi@57.0.4.patchand the matchingpnpm.patchedDependenciesentryexpo-modules-jsi@57.0.5in the lockfile (no patch)expo-modules-jsitominimumReleaseAgeExcludeuntil 2026-08-27T10:47:33Z (when 57.0.5 matures under the repo’s 7-dayminimumReleaseAge)@config-plugins/react-native-webrtcexclude in place (still needed until 2026-08-22)No published package API change; no changeset.
Test plan
pnpm installsucceedsexpo-modules-jsi@57.0.5withoutpatch_hashmilliseconds.magnitudecc @kraenhansen — please review.