Skip to content

[github workflows] Improve Env var handling #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PennyroyalTea merged 2 commits into from
Jul 27, 2026
Merged

[github workflows] Improve Env var handling #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb5ee30
use env vars to escape untrusted input
RileyWilliams Jul 25, 2026
c76ea64
pin actions by digest
RileyWilliams Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@ jobs:

steps:
- name: Check out repo
uses: actions/checkout@v3
uses: actions/checkout@a37ce9120846195fa4ece8f58b268e6043cb2f26 # v3.7.0

- name: Set up pnpm
uses: pnpm/action-setup@v4
uses: pnpm/action-setup@b906affcce14559ad1aafd4ab0e942779e9f58b1 # v4.3.0

- name: Set up node
uses: actions/setup-node@v3
uses: actions/setup-node@3235b876344d2a9aa001b8d1453c930bba69e610 # v3.9.1
with:
node-version: 20
cache: 'pnpm'
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@ jobs:

steps:
- name: Check out repo
uses: actions/checkout@v3
uses: actions/checkout@a37ce9120846195fa4ece8f58b268e6043cb2f26 # v3.7.0

- name: Set up pnpm
uses: pnpm/action-setup@v4
uses: pnpm/action-setup@b906affcce14559ad1aafd4ab0e942779e9f58b1 # v4.3.0

- name: Set up node
uses: actions/setup-node@v3
uses: actions/setup-node@3235b876344d2a9aa001b8d1453c930bba69e610 # v3.9.1
with:
node-version: 20
cache: 'pnpm'
Expand Down
23 changes: 14 additions & 9 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,18 +25,18 @@ jobs:
id-token: write
steps:
- name: Check out repo
uses: actions/checkout@v6
uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6.1.0
with:
ref: ${{ github.event.release.tag_name || inputs.tag }}

- name: Set up node
uses: actions/setup-node@v6
uses: actions/setup-node@249970729cb0ef3589644e2896645e5dc5ba9c38 # v6.5.0
with:
node-version: 20
registry-url: https://registry.npmjs.org

- name: Set up pnpm
uses: pnpm/action-setup@v4
uses: pnpm/action-setup@b906affcce14559ad1aafd4ab0e942779e9f58b1 # v4.3.0

- name: Install dependencies
run: pnpm install --frozen-lockfile
Expand All @@ -46,24 +46,29 @@ jobs:

- name: Determine publish tag
id: extract
env:
RELEASE_TAG: ${{ github.event.release.tag_name }}
INPUT_PUBLISH_TAG: ${{ inputs.publish_tag }}
run: |
if [ -n "${{ inputs.publish_tag }}" ]; then
PUBLISH_TAG="${{ inputs.publish_tag }}"
if [ -n "$INPUT_PUBLISH_TAG" ]; then
PUBLISH_TAG="$INPUT_PUBLISH_TAG"
else
FULL_TAG_NAME=${{ github.event.release.tag_name }}
FULL_TAG_NAME="$RELEASE_TAG"
if [[ "$FULL_TAG_NAME" == *"beta"* ]]; then
PUBLISH_TAG="beta"
else
PUBLISH_TAG="latest"
fi
fi
echo "PUBLISH_TAG=$PUBLISH_TAG" >> $GITHUB_ENV
echo "PUBLISH_TAG=$PUBLISH_TAG" >> "$GITHUB_ENV"

- name: Validate tag matches package.json version
env:
RAW_TAG: ${{ github.event.release.tag_name || inputs.tag }}
run: |
TAG_VERSION="${{ github.event.release.tag_name || inputs.tag }}"
TAG_VERSION="$RAW_TAG"
# Remove package name prefix if present (e.g., @elevenlabs/cli@0.3.1 -> 0.3.1)
TAG_VERSION=$(echo "$TAG_VERSION" | sed 's/.*@//')
TAG_VERSION="${TAG_VERSION##*@}"
PACKAGE_JSON_VERSION=$(node -p "require('./package.json').version")

echo "Tag version: $TAG_VERSION"
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/test-cli.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4.4.0

- name: Set up pnpm
uses: pnpm/action-setup@v4
uses: pnpm/action-setup@b906affcce14559ad1aafd4ab0e942779e9f58b1 # v4.3.0

- name: Setup Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: '20'
cache: 'pnpm'
Expand All @@ -39,7 +39,7 @@ jobs:

- name: Upload test results
if: always()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
with:
name: test-results
path: coverage/
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Check out repo
uses: actions/checkout@v3
uses: actions/checkout@a37ce9120846195fa4ece8f58b268e6043cb2f26 # v3.7.0

- name: Set up pnpm
uses: pnpm/action-setup@v4
uses: pnpm/action-setup@b906affcce14559ad1aafd4ab0e942779e9f58b1 # v4.3.0

- name: Set up node
uses: actions/setup-node@v3
uses: actions/setup-node@3235b876344d2a9aa001b8d1453c930bba69e610 # v3.9.1
with:
node-version: 20
cache: 'pnpm'
Expand Down
Loading