Skip to content

SwipeTrigger: don't hold strong reference on the actor #2806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lenemter wants to merge 2 commits into from
+20 −2
Closed

SwipeTrigger: don't hold strong reference on the actor #2806

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cce0a5
SwipeTrigger: don't hold strong reference on the actor
lenemter Apr 2, 2026
25b0369
Update lib/Gestures/SwipeTrigger.vala
lenemter Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions lib/Gestures/Triggers/SwipeTrigger.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,24 @@
* It enables touchpad and (once supported) touchscreen backends for the given actor.
*/
public class Gala.SwipeTrigger : Object, GestureTrigger {
public Clutter.Actor actor { get; construct; }
private weak Clutter.Actor? actor;
public Clutter.Orientation orientation { get; construct; }

public SwipeTrigger (Clutter.Actor actor, Clutter.Orientation orientation) {
Object (actor: actor, orientation: orientation);
Object (orientation: orientation);

this.actor = actor;
this.actor.weak_ref (on_actor_disposed);
}

~SwipeTrigger () {
if (actor != null) {
actor.weak_unref (on_actor_disposed);
}
}

private void on_actor_disposed () {
actor = null;
}

internal bool triggers (Gesture gesture) {
Expand All @@ -26,6 +39,11 @@ public class Gala.SwipeTrigger : Object, GestureTrigger {
}

internal void enable_backends (GestureController controller) {
if (actor == null) {
warning ("ScrollTrigger.enable_backends (): Can't add backends to controller: actor is null");
return;
}

controller.enable_backend (new ScrollBackend (actor, orientation, new GestureSettings ()));
}
}