Conversation
onurays
reviewed
Nov 25, 2020
onurays
reviewed
Nov 25, 2020
onurays
reviewed
Nov 25, 2020
onurays
approved these changes
Nov 25, 2020
Contributor
onurays
left a comment
onurays
left a comment
There was a problem hiding this comment.
Amazingly clean work! I just have some questions/remarks.
53 tasks
onurays
suggested changes
Nov 26, 2020
Contributor
There was a problem hiding this comment.
Some remarks:
- It is crashing if I use the "Done" button of the keyboard while adding Local Address:
Exception: java.lang.IllegalStateException: focus search returned a view that wasn't able to take focus! - There are lots of M_UNKNOWN internal errors on both Android and Web while publishing alias for the first time. I found error descriptions of Web more clear (we just show "internal error" in error dialog).
bmarty
force-pushed
the
feature/bma/alias
branch
from
110d722 to
0ac04eb
Compare
bmarty
force-pushed
the
feature/bma/alias
branch
from
0ac04eb to
b2556cb
Compare
Member
Author
Fixed For the second remark, I do not reproduce it (at the moment). We may improve this later |
…ble to take focus! And no multiline input for room alias
onurays
approved these changes
Nov 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And room directory setting. We are now iso Element Web on this point (with a better UX to publish addresses (=aliases))
Fixes #2428
Fixes #1579
Following MSC matrix-org/matrix-spec-proposals#2432
This PR also contain some cleanup on the existing code.
UI flow
New item "Room addresses" which replace the previous "Canonical alias" Edit text:
New screen, user is a regular user
New bottom sheet
When user is admin
Extended
Bottom sheet
Only address added by the user can be deleted, else the homeserver will refuse the deletion.
Published addresses
With canonical alias