Skip to content

Call for Chromedriver to stop when application is not running#933

Open
fspinillo wants to merge 1 commit intoelectron-userland:masterfrom
fspinillo:stop-chromedriver-when-app-not-running
Open

Call for Chromedriver to stop when application is not running#933
fspinillo wants to merge 1 commit intoelectron-userland:masterfrom
fspinillo:stop-chromedriver-when-app-not-running

Conversation

@fspinillo
Copy link
Copy Markdown

The current Application.stop call looks like so:

  if (!self.isRunning()) {
    return Promise.reject(Error('Application not running'));
  }

What this PR is requesting is to add in chromedriver.stop() to the above command. We've found many instances where the application crashes, but chromedriver remains open. Likely due to this call only verifying if the application is open or not before returning the promise. This leads to additional Electron instances spawning on subsequent test runs due to Chromedriver staying in the background.

We've been running a local fork of this for the last year and have found this to be a reliable way to ensure that every service that's part of Spectron fully shuts down on a crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant