Fix and greatly simplify the example app#150
Open
mlalkaka wants to merge 3 commits intoelectron-userland:masterfrom
Open
Fix and greatly simplify the example app#150mlalkaka wants to merge 3 commits intoelectron-userland:masterfrom
mlalkaka wants to merge 3 commits intoelectron-userland:masterfrom
Conversation
Perhaps there's something I'm misunderstanding here, but from what I tell, the example app in this repo has been abandoned, and doesn't actually work anymore. There are synax errors that cause it to fail at runtime, due to the use of `import` in index.html. Furthermore, there is a preload.js script that contains the same code that is in the index.html file, but that preload.js file isn't being specified when creating the `BrowserWindow` in main.js. This change fixes these issues, and in doing so, it greatly simplifies the example app.
We need to wait for document.body to become available before calling `attachToInput`. Calling from `setTimeout` accomplishes that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perhaps there's something I'm misunderstanding here, but from what I
tell, the example app in this repo has been abandoned, and doesn't
actually work anymore. There are synax errors that cause it to fail at
runtime, due to the use of
importin index.html. Furthermore, there isa preload.js script that contains the same code that is in the
index.html file, but that preload.js file isn't being specified when
creating the
BrowserWindowin main.js.This change fixes these issues, and in doing so, it greatly simplifies
the example app.