fix(nsis-web): appPackageUrl regression: stop appending arch paths to explicit URLs#9655
Draft
fix(nsis-web): appPackageUrl regression: stop appending arch paths to explicit URLs#9655
appPackageUrl regression: stop appending arch paths to explicit URLs#9655Conversation
|
…COMPLETE when URL is auto-computed Co-authored-by: mmaietta <5238867+mmaietta@users.noreply.github.com> Agent-Logs-Url: https://github.com/electron-userland/electron-builder/sessions/9dde5509-d9a6-4528-a729-9efa7ee3f1f5
Copilot
AI
changed the title
[WIP] Fix regression in nsis-web target for appPackageUrl option
Fix nsis-web Mar 24, 2026
appPackageUrl regression: stop appending arch paths to explicit URLs
appPackageUrl regression: stop appending arch paths to explicit URLsappPackageUrl regression: stop appending arch paths to explicit URLs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user explicitly sets
appPackageUrlinnsisWeb, arch-specific filenames were still being appended to it (e.g.https://example.com/download/latest/MyApp-1.0.0-x64.nsis.7z), making version-independent download URLs impossible.Root cause:
APP_PACKAGE_URL_IS_INCOMPLETEwas unconditionally set inWebInstallerTarget.configureDefines, causing the NSIS template to always append/${APP_64_NAME}(etc.) regardless of whether the URL was user-supplied or auto-computed.Changes
WebInstallerTarget.ts: Movedefines.APP_PACKAGE_URL_IS_INCOMPLETE = nullinside theif (appPackageUrl == null)branch — the flag is now only set when the URL is auto-computed from publish configs (a base URL that genuinely needs arch filename appended at runtime). An explicitappPackageUrlis used as-is.webInstallerTest.ts: Add regression test asserting thatAPP_PACKAGE_URL_IS_INCOMPLETEis absent from defines whenappPackageUrlis explicitly provided.Original prompt
appPackageUrloption #8581📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.