Skip to content

docs: say why the differences list exists, and record the emitter return values - #187

Merged
electrohyun merged 3 commits into
mainfrom
docs/differences-intro-and-returns
Aug 7, 2026
Merged

docs: say why the differences list exists, and record the emitter return values#187
electrohyun merged 3 commits into
mainfrom
docs/differences-intro-and-returns

Conversation

@electrohyun

@electrohyun electrohyun commented Aug 7, 2026

Copy link
Copy Markdown
Owner

Summary

Two changes to differences.md.

The page now says why it exists. Its value comes from how much else matches: a mock that is right almost everywhere gives a reader no reason to keep checking, and the reader who has stopped checking is the one a divergence reaches.

It also records a divergence that was not written down. socket.io returns the socket from socket.emit, socket.on, and the listener methods, and true from Server#emit and a broadcast operator's emit. smocket returns undefined in all of them, so socket.on('a', f).on('b', g) throws. This was found by installing the package from outside and using it, not by the suite, which never read a return value.

That entry goes in a new section C rather than in section A. Section A is titled "where smocket deliberately differs" and every entry there links to the decision behind it. This one is nobody's decision, and putting it in A would have broken the version rule as well as the heading: 0019 reads removing a section A entry as a major, so fixing the return values would have been judged a major purely because of which list the gap was written on, while the same fix judged on its own merits is a fidelity correction. Section C says what it holds, that its entries are expected to disappear, and which row governs closing one.

Section A is decisions, B is what smocket adds, C is what is simply missing. The three carry different version consequences, so they are three lists.

Related issue

No tracking issue. #189 removes the section C entry this adds, which is the case section C exists to keep off the section A row.

Checklist

@electrohyun electrohyun self-assigned this Aug 7, 2026
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@electrohyun, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 14 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9298fd52-4f93-4a08-822b-2d81a8b565a7

📥 Commits

Reviewing files that changed from the base of the PR and between 8e6e012 and 11b5ad6.

📒 Files selected for processing (1)
  • docs/differences.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Aug 7, 2026
@electrohyun
electrohyun merged commit f8d4eea into main Aug 7, 2026
15 checks passed
@electrohyun
electrohyun deleted the docs/differences-intro-and-returns branch August 7, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant