[Chore] Add nightly schedule#9776
Conversation
weronikaolejniczak
added
infrastructure
skip-vrt
weronikaolejniczak
changed the title
weronikaolejniczak
changed the title
e414cfc to
554c809
Compare
554c809 to
aa7fdc1
Compare
There was a problem hiding this comment.
Pull request overview
Adds a scheduled (“nightly”) execution path to the Kibana dependency update / integration-test workflow chain, so it can run without an originating PR and report results via Slack.
Changes:
- Added a weekday schedule trigger to
update_kibana_dependencies.yml, with logic to mark scheduled runs as nightly. - Extended the prepare/open-PR subworkflows to support nightly runs (fixed branch reuse, PR body enrichment with EUI snapshot/changelog details).
- Added Slack notification output for nightly runs, including optional Buildkite link discovery.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/update_kibana_dependencies.yml | Adds weekday schedule trigger and nightly dispatch args to the release workflow. |
| .github/workflows/update_kibana_dependencies__prepare_changes.yml | Adds nightly inputs + fixed branch/force-push behavior; forwards nightly metadata to the open-PR workflow. |
| .github/workflows/update_kibana_dependencies__open_pr.yml | Adds nightly PR body generation (including changelog entries) and Slack webhook notification. |
| .github/workflows/release.yml | Passes nightly metadata (EUI ref/version/last release) into the Kibana integration workflow chain. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| concurrency: | ||
| group: ${{ inputs.kibana_nightly && 'kibana-nightly' || format('release-{0}', github.run_id) }} | ||
| cancel-in-progress: false | ||
| queue: max |
There was a problem hiding this comment.
Concurrency also supports queue: max as per (source):
To allow more than one pending job or workflow run to wait in the same concurrency group, use the optional queue property. The queue property accepts the following values:
single (default): At most one job or workflow run can be pending in the concurrency group. When a new job or workflow run is queued, any existing pending job or workflow run in the same group is canceled and replaced.
max: Up to 100 jobs or workflow runs can be pending in the concurrency group. When the queue is full, any additional jobs or workflow runs are canceled.
The reason we're using it is because we have 3 separately dispatched workflows, so we want a FIFO queue and not a single workflow.
| changelog_entries+="$(< "$changelog_file")" | ||
| done < <( | ||
| find packages/eui/changelogs/upcoming -maxdepth 1 -type f \ | ||
| -name '*.md' ! -name '_template.md' | sort |
There was a problem hiding this comment.
Nit, non-blocking: Would sort -V make sense to ensure correct numerical order?
mgadewoll
left a comment
mgadewoll
left a comment
There was a problem hiding this comment.
🟢 LGTM, let's ship and test! 🚢
Summary
Closes https://github.com/elastic/eui-private/issues/718
Closes https://github.com/elastic/eui-private/issues/712
update_kibana_dependencies*workflows to support non-PR updates.update_kibana_dependenciesworkflow trigger based on a schedule:- cron: '0 3 * * 1-5'.#eui-corechannel, and added in the repo asKIBANA_NIGHTLY_SLACK_WEBHOOK. Instead of commenting on a source PR (that doesn't exist), it sends notifications in Slack.QA instructions for reviewer
Not possible to test until merged to
main.