Repository navigation
docs(nim): add nim-wfm chart parameter reference to the Helm guide - #59
Merged
Merged
Conversation
Add a Chart parameters section at the end of the Helm guide. The reference is generated from the nim-wfm 1.3.0 chart values (the chart README Parameters tables and the @PARAM annotations in values.yaml), grouped by the chart's own sections. Parameters the chart marks as legacy or deprecated are omitted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Chart parameters reference at the end of
helm.md(Deployment, Autoscaling, Ingress, Probe, Helm test, Metrics, Models, Storage, Service), taken from thenim-wfm1.3.0 chart README parameter tables (generated from the chart's@paramannotations) and checked against itsvalues.yaml. Parameters the chart marks legacy or deprecated are omitted. This closes the coverage gap with the parameter reference on the current NIM docs site, whose tables no longer match chart 1.3.0.Review notes
image.repositorydefaults to a non-Cosmos image andmodel.nimCacheto/model-store; the page's example values override both.persistence.enabled: true; otherwise the chart falls back toemptyDir.model.selection.type/variant/precision/performanceProfilefor the Cosmos selectors; the page sets them throughenv, and the chart rejects setting the same selector in both places.tolerationsreplaces the chart's defaultnvidia.com/gputoleration.Docs-only change; pages were not rendered locally.
🤖 Generated with Claude Code