splitMap - added targets field#336
Open
earthspacon wants to merge 7 commits intoeffector:mainfrom
Open
Conversation
Contributor
Author
sergeysova
reviewed
Sep 25, 2024
Member
|
Added new section to a checklist to help integrating with new documentation website |
Contributor
Author
|
@sergeysova can you help plz with tests in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR partially resolves this issue.
Often we need the same behavior as in split — react to derived events received from
casesand trigger the corresponding units. Intargetsfield we can pass object with the same keys as incasesand values withunitsto trigger on the corresponding event.Maybe we should think about
targetsnamingChecklist
src/method-name/method-name.test.tssrc/method-name/method-name.fork.test.tstest-typings/method-name.ts// @ts-expect-errorto mark expected type errorimport { expectType } from 'tsd'to check expected return typesrc/method-name/readme.mdPatronum/MethodNameMotivation,Formulae,ArgumentsandReturnsections for each overloadExamplesection for each overloadsrc/method-name/readme.mdtitle. Make sure it uses camelCase syntax just like the method itselfslug. Use param-case to write it. In most cases it will be just liketitledesriptionwith one short sentence describing what method useful forgroup. To categorize method on/operatorspage. Full list of available groups, you can see in documentation/src/content/config.ts