Skip to content

Update base image, pip, add pip cache. #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ways wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Update base image, pip, add pip cache. #159

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0623be6
Update base image, pip, add pip cache.
ways Mar 4, 2026
6daa104
Add docker syntax and use pip via python -m.
ways Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,19 @@
# Run the container with:
# docker run --rm -it -v `pwd`:/src eccodes-python
#
FROM bopen/ubuntu-pyenv:latest
FROM python:3.9-slim
Comment thread
ways marked this conversation as resolved.

ARG DEBIAN_FRONTEND="noninteractive"

RUN apt-get -y update && apt-get install -y --no-install-recommends \
build-essential \
libeccodes0 \
&& rm -rf /var/lib/apt/lists/*

COPY . /src/

RUN cd /src \
RUN --mount=type=cache,target=/root/.cache/pip cd /src \
Comment thread
ways marked this conversation as resolved.
&& pip install --upgrade pip \
Comment thread
ways marked this conversation as resolved.
Outdated

Copilot AI Mar 5, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading pip without pinning can make image builds non-reproducible (pip behavior can change across releases). Consider pinning pip to a known-good version (or using a constraints file) to stabilize builds over time.

Copilot uses AI. Check for mistakes.

@ways ways Mar 6, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think pip should always be at the latest version. For other packages I agree.

&& make local-install-test-req \
&& make local-develop \
&& make local-install-dev-req \
Expand Down