Support extended keepalive parameters in epoll and io_uring#6089
Open
ivu-mawi wants to merge 2 commits into
Open
Support extended keepalive parameters in epoll and io_uring#6089ivu-mawi wants to merge 2 commits into
ivu-mawi wants to merge 2 commits into
Conversation
Member
|
I am wondering for the new config to potentially have an Option object to be more extensible than what we have now. |
Member
|
@ivu-mawi I have introduced generic TCP option, can you rebase on master |
Member
|
that only affects the new config |
Author
|
Seems good! I'll gladly rebase when I get the chance, which will be next week only I'm afraid. |
Member
|
No problem @ivu-mawi . Thank you! |
ivu-mawi
force-pushed
the
epoll-keepalive-extended-params-master
branch
from
9a4a2f0 to
fd5a51c
Compare
ivu-mawi
changed the title
Member
|
why is that PR still in draft mode ? |
Author
|
I'm trying to verify locally that it actually works. But I can't seem to get packet capturing to work in WSL (Windows subsystem for linux), and that's the only Linux I have access to at the moment. :( I'll give up the test. Code is ready, I'll mark it ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EpollTransport: support extended keepalive parameters TCP_KEEPIDLE, TCP_KEEPCNT and TCP_KEEPINTVL
Builds on #5183. This work has not made it into master, so I'm catching up on that.
I hope I've ported it correctly given the refactoring of the TCPSSLOptions / TCPConfig.
For motivation, see #5163 and #5183 and #5970