HTML tooltip on form fields#2145
Open
seesack wants to merge 1 commit into
Open
Conversation
cguglielmo
reviewed
Apr 23, 2026
Member
cguglielmo
left a comment
cguglielmo
left a comment
There was a problem hiding this comment.
- Please add specs
- The SequenceBox pulls the tooltip from the last field up, this property should be pulled up as well, otherwise the tooltip content would be encoded if the field is the last field in a SequenceBox.
- Please add a checkbox for the new property in the JS-Widgets-App
The field status creation changed with 26.1. I created a PR for 26.2 with the necessary adjustments and also added specs. However, the changes for the SequenceBox are still open: #2158
| this._updateTooltip(); | ||
| } | ||
|
|
||
| /** @see FormFieldModel.tooltipText */ |
Member
There was a problem hiding this comment.
The JS doc should link tooltipHtmlEnabled not tooltipText
| } | ||
|
|
||
| /** @internal */ | ||
| _renderTooltipHtmlEnabled() { |
Member
There was a problem hiding this comment.
Use protected instead and remove the internal JS doc because it is not used from outside of the class.
| parent: this, | ||
| $anchor: this.$container, | ||
| text: this.status.message, | ||
| htmlEnabled: this.tooltipHtmlEnabled, |
Member
There was a problem hiding this comment.
Also call the setter after line 196 so it can be changed while the tooltip is open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.